This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix(): fix sidenav scroll subscription #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Oct 6, 2017
| // to subscribe to its scroll event until next tick (when it does exist). | ||
| Promise.resolve().then(() => { | ||
| this._scrollContainer = this.container ? | ||
| this._document.querySelectorAll(this.container)[0] : window; |
There was a problem hiding this comment.
You can use querySelector instead of querySelectorAll(...)[0].
There was a problem hiding this comment.
I'm just copy-pasting what was there before into a Promise, but I can update if you want.
crisbeto
reviewed
Oct 6, 2017
| .subscribe(() => this.onScroll()); | ||
| // On init, the sidenav content element doesn't yet exist, so it's not possible | ||
| // to subscribe to its scroll event until next tick (when it does exist). | ||
| Promise.resolve().then(() => { |
There was a problem hiding this comment.
Couldn't you do this in one of the other lifecycle hooks?
There was a problem hiding this comment.
Fair point. I can move to ngAfterViewInit.
There was a problem hiding this comment.
Edit: this appears not to work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.