Page title is not correctly updated (#296)

[sumiet]

Hey, I am new to OSS and this would be my first contribution. Please review the PR.

[sumiet]

I am a little bit confused here, the build is working perfectly for my local and also I haven't modified anything on package.json. Why is npm install still failing. Please guide, I am new to the community and not much aware about the procedure here.

[willshowell]

Thanks for the PR!

The Travis builds have been failing for a while due to some other commit.

I think this behavior should be added to ComponentCategoryList , instead of ComponentSidenav. Also, any subscription needs to be unsubscribed from in ngOnDestroy.

[sumiet]

@willshowell I have implemented the comments, please review.

[willshowell]

Try this, it's a little simpler

this.routeParamSubscription = this.params.subscribe(params => {
  const sectionName = params['section'];
  this._componentPageTitle.title = SECTIONS[sectionName];;
});

[sumiet]

Thanks @willshowell, implemented the changes. Please review.

[willshowell]

Pinging @jelbourn for review

[sumiet]

@jelbourn can you please review this.

[sumiet]

@willshowell shall I wait for the reviews? or should I try something else. I am really new to this please guide.

[willshowell]

@sumiet I think your approach is fine - the team will let you know if you need to try something else. I can't speak for them, but it looks like there is a race to get a stable release out soon, so fixing docs site bugs are probably a lower priority than usual.

[jelbourn]

I'm trying to make the CI green first presently

[sumiet]

@willshowell @jelbourn Okay thanks for the updates.

[jelbourn]

@amcdnl can you review?

[amcdnl]

LGTM