Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix(tests): fix tests on CI #411

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Mar 14, 2018

  • Remove e2e tests which acted as no-op.
  • Fix unit tests
  • Update to Angular and Material 6 betas.

@josephperrott josephperrott force-pushed the test-fix branch 4 times, most recently from cede7b9 to 444304a Compare March 14, 2018 19:15
@josephperrott josephperrott changed the title fix(tests): fix tests throughout app fix(tests): fix unit tests throughout app Mar 14, 2018
@josephperrott josephperrott force-pushed the test-fix branch 5 times, most recently from 60c6480 to af36dff Compare March 14, 2018 20:29
@josephperrott josephperrott changed the title fix(tests): fix unit tests throughout app fix(tests): fix tests on CI Mar 14, 2018
@@ -17,6 +17,12 @@ const mockActivatedRoute = {
fragment: Observable.create(observer => {
observer.complete();
}),
parent: {
params: Observable.create(observer => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

observableOf({})?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from Miles' comment

@jelbourn jelbourn merged commit fa29148 into angular:master Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants