Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

build: ensure docs-content is up-to-date before deploy #505

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Aug 15, 2018

  • Currently the fetch-assets script always fetches the data from the master branch. This is problematic because if we release a new patch release, we will incorrectly have the docs content for the upcoming major version. Adds the possibility to fetch the docs-content from a given branch (e.g. 6.4.x)
  • Adds a small note to the deploy script that makes the publisher aware of the docs-content, which should be kept updated.

This is related to angular/components#12690 (comment)

* Currently the `fetch-assets` script always fetches the data from the `master` branch. This is problematic because if we release a new patch release, we will incorrectly have the docs content for the upcoming major version.
* Adds a small note that makes the publisher aware of the docs-content that should be kept updated.
@googlebot
Copy link
Collaborator

☹️ Sorry, but only Googlers may change the label cla: yes.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f12159b into angular:master Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants