This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix: table of contents not working within cdk #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intentionally reset the scroll position on navigation if the component view changed (e.g. if you switch from components/button to components/slider). Unfortunately this outdated check causes the CDK ToC to not work. This has been like that for V6 as well. In order to make the ToC work for the CDK, we need to make sure that we don't reset the scroll position if someone navigates within a CDK doc entry.
Splaktar
approved these changes
Oct 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intentionally reset the scroll position on navigation if the component view changed (e.g. if you switch from components/button to components/slider). Unfortunately this outdated check causes the CDK ToC to not work. This has been like that for V6 as well.
In order to make the ToC work for the CDK, we need to make sure that we don't reset the scroll position if someone navigates within a CDK doc entry.