This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix: correct links in doc-viewer markdown files to have the proper base value #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
reviewed
Oct 30, 2018
| private updateDocument(rawDocument: string) { | ||
| // Replaces all hash base links with the current path | ||
| const correctedDocument = rawDocument.replace( | ||
| /(<a href="#)+/g, `<a href="${window.location.pathname}#`); |
There was a problem hiding this comment.
Could you run this through DomSanitizer.sanitize?
josephperrott
force-pushed
the
correct-md-links
branch
from
7409f3c to
b2db260
Compare
|
@josephperrott looks like the tst fails now |
josephperrott
force-pushed
the
correct-md-links
branch
from
b2db260 to
6726c8a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes angular/components#13875