This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix: accessibility, SEO, typos, styling, favicons #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Oct 12, 2019
| @@ -5,19 +5,23 @@ | |||
| <div class="footer-logo"> | |||
| <img class="docs-footer-angular-logo" | |||
| src="../../../assets/img/homepage/angular-white-transparent.svg" | |||
| alt="angular"> | |||
| alt="Angular icon"> | |||
There was a problem hiding this comment.
Shouldn't it be "Angular logo"?
There was a problem hiding this comment.
Not based on https://hudsonvalleygraphics.com/is-it-a-logo-or-an-icon/ which aligns with my thinking that most logos include some typography.
https://blog.designcrowd.com/article/353/differences-between-logos-and-icons also mentions that icons are generally quadratic/square.
Here's the Angular logo: https://angular.io/assets/images/logos/angular/[email protected]
| <span><a href="https://angular.io">Learn Angular</a></span> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="docs-footer-version"> | ||
| <img class="angular-material-logo" src="../../../assets/img/angular-material-logo.svg" | ||
| alt="Angular Material icon"> |
There was a problem hiding this comment.
Should also say that it's the logo.
Splaktar
force-pushed
the
fixLighthouseIssues
branch
from
78833d7 to
27ad8cb
Compare
add lang to html tag add robots.txt and sitemap.xml enable build-optimizer add Angular Material icon to footer fix typos use accent color on 2nd Get started button on homepage improve page title SEO better format copyright in footer add structured data, open graph, twitter to index preconnect and dns-prefetch fonts add apple-touch-icon links add site description, keywords, author, theme-color, Content-Type, etc. update favicons to Angular Material icons - support macOS touchbar and Windows 8/10 icons disable Angular CLI commonChunk refactor `main.scss` to `styles.scss` to be consistent with CLI
Splaktar
force-pushed
the
fixLighthouseIssues
branch
from
27ad8cb to
591ef25
Compare
Splaktar
changed the title
![https://angular.io/assets/images/logos/angular/[email protected]](https://angular.io/assets/images/logos/angular/logo-nav@2x.png){kind=link}
Splaktar
added a commit
that referenced
this pull request
Oct 15, 2019
add lang to html tag add robots.txt and sitemap.xml enable build-optimizer add Angular Material icon to footer fix typos use accent color on 2nd Get started button on homepage improve page title SEO better format copyright in footer add structured data, open graph, twitter to index preconnect and dns-prefetch fonts add apple-touch-icon links add site description, keywords, author, theme-color, Content-Type, etc. update favicons to Angular Material icons - support macOS touchbar and Windows 8/10 icons
Splaktar
added a commit
that referenced
this pull request
Oct 15, 2019
add lang to html tag add robots.txt and sitemap.xml enable build-optimizer add Angular Material icon to footer fix typos use accent color on 2nd Get started button on homepage improve page title SEO better format copyright in footer add structured data, open graph, twitter to index preconnect and dns-prefetch fonts add apple-touch-icon links add site description, keywords, author, theme-color, Content-Type, etc. update favicons to Angular Material icons - support macOS touchbar and Windows 8/10 icons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.scsstostyles.scssto be consistent with CLIBefore
Twitter
No preview.
Structured Data
None found.
Google
Favicon checks
After
Twitter
Structured Data
Google preview
Favicon checks
With assistance from https://realfavicongenerator.net