Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix(docs): correct overflow cdk pages #651

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

donroyco
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or weren't appropriate

What is the current behavior?

Content on mobile devices overflows on certain pages in CDK.

Issue Number:
#550

What is the new behavior?

Content does not overflow anymore.

Other information

Before
Before state of CDK pages

After
After state of CDK pages

Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@andrewseguin
Copy link
Collaborator

This broke the layout for desktop mode, where the left nav is displayed showing the Material components. With this change, the API docs show below the navigation, leaving an open whitespace to the right of the nav

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants