fix: header not working correctly #687
Conversation
|
Can you please take a look at the issue and fix in #657 to make sure that we aren't re-introducing the same issue on desktop here? |
|
After checking I found out that this does not lead to the same issues you can also have a check |
|
@crisbeto can you please review this. |
|
On what browser does the original issue happen on? I tried against Chrome, Firefox and IE, but I couldn't reproduce it after resizing the window down so the example doesn't fit. |
|
@crisbeto it was happen ing on all browsers. I checked on Chrome and Mozilla. I'm also attaching a video link for your reference. Steps to reproduce open: https://material.angular.io/components/datepicker/overview https://drive.google.com/file/d/1W49_QHKFNpWUqgmyWqNLv1mFSh6SEejt/view?usp=drivesdk |
|
@crisbeto please tell me if you are not able to recreate it. |
|
ok, I see what you mean now. I'm not sure that this the way to go though. If you scroll all the way to the bottom you can see that we now have an extra scrollbar:
|
|
@crisbeto you have any other suggestions that is what I intended to do. |
|
Ideally it should stretch out to the edge of the screen and let the page have the horizontal overflow. I'm having a hard time to behave that way though. |
|
@crisbeto I've hidden the scrollbars using CSS seems like a valid solution to me |
Fixes #686 ,closes #687, fixes #550 - fix docs-api layouts to work down to 360px width - fixes Observers, Accessibility, Drag and Drop, Platform, and Overlay layouts - fix DeprecatedconnectedTo to Deprecated connectedTo display issue - update footer copyright - fix exception trying to unsubscribe to undefined routeParamSubscription - change how sidenav is closed on mobile after selecting a nav item
Fixes #686
The header is not working correctly when content takes more width than the viewport. Check the attached screenshot. Now make the body scroll if it takes more with than the screen.