This repository was archived by the owner on Dec 18, 2024. It is now read-only.
follow-up improvements to components list page #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
approved these changes
Jun 8, 2020
mmalerba
approved these changes
Jun 9, 2020
|
Before: After: I think lightening the text makes it a little better |
mmalerba
reviewed
Jun 9, 2020
Splaktar
reviewed
Feb 6, 2021
| @@ -49,7 +49,7 @@ import {NavigationFocusService} from '../../shared/navigation-focus/navigation-f | |||
| // These breakpoint values need to stay in sync with the related Sass variables in | |||
| // src/styles/_constants.scss. | |||
| const EXTRA_SMALL_WIDTH_BREAKPOINT = 720; | |||
| const SMALL_WIDTH_BREAKPOINT = 959; | |||
| const SMALL_WIDTH_BREAKPOINT = 939; | |||
There was a problem hiding this comment.
I think that it's problematic that this small breakpoint was changed so that it no longer matches our Sass small breakpoint (mentioned in the comments above this const):
It also no longer matches any of the established Material Design layout breakpoints:
https://material.io/design/layout/responsive-layout-grid.html#breakpoints
I'm looking at reverting this in #257.
Splaktar
added a commit
to DevIntent/material.angular.io
that referenced
this pull request
Feb 6, 2021
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
Splaktar
added a commit
to DevIntent/material.angular.io
that referenced
this pull request
Feb 7, 2021
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
Splaktar
added a commit
to DevIntent/material.angular.io
that referenced
this pull request
Feb 7, 2021
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
annieyw
pushed a commit
that referenced
this pull request
Feb 8, 2021
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from #784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes #257
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of #760