Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

add logo and link to angular in footer #79

Merged
merged 2 commits into from
Jan 10, 2017

Conversation

amitafr
Copy link
Contributor

@amitafr amitafr commented Jan 7, 2017

Added Angular logo and link to angular.io in footer to match microsite templates

font-size: 12px;
}

.footer-list {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.docs-footer-list

width: 8.33%;
}

.footer-cc {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.docs-footer-copyright

padding: 8px;
}

.docs-angular-logo {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.docs-footer-angular-logo

</div>

<div class="footer-links">
<ul class="footer-links">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is having two elements with the same class intentional?

justify-content: flex-end;
}

footer ul {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these styles use the css classes instead? There's already a class on the ul

flex-direction: column;
}
.footer-logo {
width: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display: none?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1910483 into angular:master Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants