Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

build: run ng update migrations for v12-next #932

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Mar 16, 2021

  • update StackBlitz for v12-next
  • add v12-next to version list
  • fix warnings about --prod being deprecated

build: update to Angular 12.0.0-next.5 and typescript 4.2.3

  • this fixes the broken form-field examples

You can try it here: https://angularmaterial.dev/

@annieyw
Copy link
Contributor

annieyw commented Mar 16, 2021

I think the stackblitz update is messing with the examples:
https://angularmaterial.dev/components/autocomplete/examples

@Splaktar
Copy link
Contributor Author

Doh, that doesn't look good. Thank you for the heads up. I'll take a look later today after some meetings.

@Splaktar
Copy link
Contributor Author

I looked into this some more and the autocomplete examples are broken on https://next.material.angular.io/components/autocomplete/examples as well. So this isn't an issue introduced with this PR, but I will look into resolving it.

- update StackBlitz for v12-next
- add v12-next to version list
- fix warnings about `--prod` being deprecated
@Splaktar
Copy link
Contributor Author

So this is looking like either Angular core is broken or some edge case of how we dynamically load components is broken. I'm going to open a separate issue for this in angular/components since it seems related to how we generate component-examples.

@Splaktar
Copy link
Contributor Author

Here's the issue to track these form-field example issues: angular/components#22285

@Splaktar
Copy link
Contributor Author

OK, next.5 CLI build deployed as well. This should be ready to merge.

@andrewseguin andrewseguin merged commit ff7b516 into angular:master Mar 18, 2021
@Splaktar Splaktar deleted the ng-update branch March 18, 2021 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants