This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(util): remove argument type for err #3451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cnishina
commented
Aug 5, 2016
cnishina
commented
- Fix argument of type 'string | Error' is not assignable to parameter of type 'string'.
- Fix argument of type 'string | Error' is not assignable to parameter of type 'string'.
| err.stack = exports.filterStackTrace(err.stack); | ||
| throw err; | ||
| }); | ||
| let results = when(filenameOrFn.apply(null, args), null, (err) => { |
There was a problem hiding this comment.
Surprised no type is needed for err but alright
There was a problem hiding this comment.
Looked into this and DefinitelyTyped q.when has defined a callback onRejected?: (reason: any).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.