-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(config): Add 'random' and 'seed' Jasmine config options #3467
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! On 11 August 2016 at 15:11, googlebot [email protected] wrote:
|
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
The one thing that I'm not sure of is how to show a custom text once all specs are finished. In jasmine-npm console reporter they show what seed was used to randomize specs, which may be useful if your tests fail and you want to restart them in the exact same order, thus using the same seed. |
Good idea! Why not throw it on to |
Turns out that Protractor doesn't have to handle printing of the seed used, as Jasmine reporters should take care of this. I'm using a custom reporter (SpecReporter) instead of the default one, which doesn't seem to print it out, but when I switched back to the default one, I got:
so it looks like everything is ok. |
@sjelin My PR to jasmine-spec-reporter to show the seed used has been merged recently and now I'm getting the following output with the latest jasmine-spec-reporter and protractor that includes this PR:
so I think that this PR can be merged as it is. |
Please rebase. |
1424150
to
d1f6d9b
Compare
Feature Request
This adds handling of
random
andseed
options injasmineNodeOpts
and allows to run specs in random order. The descriptions for both options are taken from Jasmine docs.Running specs in random order is usually preferable, as it ensures that the tests don't depend on each other and don't leak unwanted changes.
Nope.