This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(typings): Update selenium typings and fix tsc errors #4158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first crack at solving the typing issues raised in #4148. I picked up some of the low-hanging fruit in regards to typing fixes
Disclaimer: I'm still getting used to the TS ecosystem, so if I missed something obvious here please educate me 😄
Also, on a side note, who would we feel about bumping TS to
2.1.x
? We are still on2.x
; I know there's hesitancy about moving to2.2
or2.3
so we could also wait until those are more accepted in the angular/angular tooling community.