Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

deps(webdriver_js_extender): update webdriver_js_extender to 2.1 #4911

Closed

Conversation

ventuno
Copy link
Contributor

@ventuno ventuno commented Aug 8, 2018

Following up on angular/webdriver-js-extender#21, updating webdriver-js-extender to version 2.1.0.

Making the 2 new endpoints to send custom commands to the DevTools debugger server (available since ChromeDriver version 2.30 [1]):

  • /chromium/send_command;
  • /chromium/send_command_and_get_result.

available for use in protractor.

@qiyigg as you already reviewed the other PR, is there any chance you could take a look at this one as well?

[1] https://chromium.googlesource.com/chromium/src/+/711de0efbb675bd2a4a28ec47c9194d8e498e600

@ventuno ventuno force-pushed the update-webdriver-js-extender-2.1.0 branch 2 times, most recently from c8d74b4 to 8da94b0 Compare August 9, 2018 03:53
@ventuno ventuno changed the title Update [email protected]. deps(webdriver_js_extender): update webdriver_js_extender to 2.1 Aug 9, 2018
@ventuno
Copy link
Contributor Author

ventuno commented Aug 9, 2018

@qiyigg would it be possible to restart the circleci build? I made no real changes besides squashing two commits into one and updating the commit message to match the required format. circleci build was green last night [1] and is red now, while travis-ci build was red last night and is green now, so I'm assuming tests may be a little flaky.

[1] https://circleci.com/gh/angular/protractor/1111

@qiyigg
Copy link
Contributor

qiyigg commented Aug 14, 2018

rebuilt.
But the package-lock.json file change is surprising to me. Why update webdriver_js_extender from 2.0 to 2.1 will bring lots of dependency changes. Could you verify that?

@ventuno
Copy link
Contributor Author

ventuno commented Aug 14, 2018

Thanks @qiyigg, a lot of the dependency versions in package.json are defined as ^ or ~ so when we run npm install the latest minor/patch version update will be automatically installed.
This is not directly related to updating webdriver_js_extender, rather in the last 28 days (e.g.: the last time the package.json file was changed) a lot of new versions have been released.

Does that make sense?

[1] https://github.com/angular/protractor/blob/master/package.json

@qiyigg
Copy link
Contributor

qiyigg commented Aug 17, 2018

No, it shouldn't. It should only updates the dependencies that are mismatched in package.json and package-lock.json as long as you just run "npm i", not "npm update".

But I found I forgot to update package-lock.json during last release. Sent another PR to do this: #4931 (You can also find it only update the mismatched dependencies).

@ventuno ventuno force-pushed the update-webdriver-js-extender-2.1.0 branch from d1a5d9a to 3007396 Compare August 18, 2018 06:41
@ventuno
Copy link
Contributor Author

ventuno commented Aug 18, 2018

Thanks @qiyigg, I followed your instructions, let me know if this looks better to you now. I can also wait until #4931 is merged and rebase my changes after.

Also, all builds are green now :-).

@qiyigg
Copy link
Contributor

qiyigg commented Aug 21, 2018

@ventuno #4931 is merged.
I guess you have to revert your package-lock.json change first, then rebase, then run 'npm i'.

@ventuno
Copy link
Contributor Author

ventuno commented Aug 22, 2018

@qiyigg rebasing had become too complicated, so made again all changes in #4934 and closing this one.

@ventuno ventuno closed this Aug 22, 2018
@ventuno ventuno deleted the update-webdriver-js-extender-2.1.0 branch August 22, 2018 04:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants