Skip to content

Commit 08a5aec

Browse files
author
Keen Yee Liau
authored
fix: remove message about disabled LS if ngcc fails (#1359)
The log message is misleading because LS is enable even if ngcc fails.
1 parent 458efc8 commit 08a5aec

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

server/src/session.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,9 +1111,9 @@ export class Session {
11111111
success = true;
11121112
} catch (e) {
11131113
this.error(
1114-
`Failed to run ngcc for ${configFilePath}:\n` +
1115-
` ${e.message}\n` +
1116-
` Language service will remain disabled.`);
1114+
`Failed to run ngcc for ${
1115+
configFilePath}, language service may not operate correctly:\n` +
1116+
` ${e.message}`);
11171117
} finally {
11181118
this.connection.sendProgress(NgccProgressType, NgccProgressToken, {
11191119
done: true,
@@ -1157,4 +1157,4 @@ function isTypeScriptFile(path: string): boolean {
11571157

11581158
function isExternalTemplate(path: string): boolean {
11591159
return !isTypeScriptFile(path);
1160-
}
1160+
}

0 commit comments

Comments
 (0)