Skip to content

fix: remove angular.ngdk configuration #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented May 17, 2021

This configuration does not work well in practice because we cannot guarantee
the compatibility between the extension and an older version of
@angular/language-service.

If users have to revert to an older version for any reason, they should
download an older extension from the VSCode marketplace.

Close #1325

This configuration does not work well in practice because we cannot guarantee
the compatibility between the extension and an older version of
`@angular/language-service`.

If users have to revert to an older version for any reason, they should
download an older extension from the VSCode marketplace.

Close angular#1325
@kyliau kyliau added the target: patch This PR is targeted for the next patch release label May 17, 2021
@kyliau kyliau requested a review from atscott May 17, 2021 23:04
@google-cla google-cla bot added the cla: yes label May 17, 2021
@atscott atscott added the action: merge Ready to merge label May 17, 2021
@atscott atscott merged commit fb0b900 into angular:master May 18, 2021
atscott pushed a commit that referenced this pull request May 18, 2021
This configuration does not work well in practice because we cannot guarantee
the compatibility between the extension and an older version of
`@angular/language-service`.

If users have to revert to an older version for any reason, they should
download an older extension from the VSCode marketplace.

Close #1325

(cherry picked from commit fb0b900)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular.ngdk override setting does not work as expected
2 participants