test: quality of life updates for e2e tests #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
atscott
commented
May 19, 2021
atscott
commented
- update vscode version
- use __dirname for resolving test file locations to be more fault tolerant of potential errors in directory resolution
- wait for definitions to be available during activation rather than waiting a set time
atscott
force-pushed
the
e2etestupdates
branch
2 times, most recently
from
f0cec9b to
7bad2ec
Compare
kyliau
reviewed
Jun 1, 2021
kyliau
approved these changes
Jun 1, 2021
atscott
added
action: merge
atscott
added a commit
that referenced
this pull request
Jun 8, 2021
Co-authored-by: Renovate Bot <[email protected]> (cherry picked from commit 87c1b70)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.