fix: unchanged files sometimes have no Angular information for string… #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
approved these changes
Jul 28, 2021
…s when first opened The `TextStorage` in TS server calls `useScriptVersionCacheIfValidOrOpen` in many places when dealing with a `ScriptInfo`. One of the conditions in that function is to switch to version _if the script is open_. This change in version results in an identity change for the `SourceFile` which is problematic for the compiler because we store references to string literals for inline templates, template URLs, and style URLs. These references will not be valid if the `SourceFile` changed identity. To ensure that the compiler is aware of the change, we mark the project as dirty when a text document is opened. This will cause the project to call `updateGraph`, determine that the file changed versions, and create a new program. This is done so that the Angular compiler can reprocess the file. This also appears to be one of, if not the only issue, that's currently causing the e2e tests to be flaky.
* Fix test output so that it logs to console. * Disable hover tests because they are flaky.
atscott
added a commit
that referenced
this pull request
Jul 28, 2021
#1453) * fix: unchanged files sometimes have no Angular information for strings when first opened The `TextStorage` in TS server calls `useScriptVersionCacheIfValidOrOpen` in many places when dealing with a `ScriptInfo`. One of the conditions in that function is to switch to version _if the script is open_. This change in version results in an identity change for the `SourceFile` which is problematic for the compiler because we store references to string literals for inline templates, template URLs, and style URLs. These references will not be valid if the `SourceFile` changed identity. To ensure that the compiler is aware of the change, we mark the project as dirty when a text document is opened. This will cause the project to call `updateGraph`, determine that the file changed versions, and create a new program. This is done so that the Angular compiler can reprocess the file. This also appears to be one of, if not the only issue, that's currently causing the e2e tests to be flaky. * test: Stabalize e2e tests * Fix test output so that it logs to console. * Disable hover tests because they are flaky. (cherry picked from commit a751e61)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s when first opened
The
TextStoragein TS server callsuseScriptVersionCacheIfValidOrOpenin many placeswhen dealing with a
ScriptInfo. One of the conditions in that functionis to switch to version if the script is open. This change in version
results in an identity change for the
SourceFilewhich is problematicfor the compiler because we store references to string literals for
inline templates, template URLs, and style URLs. These references will
not be valid if the
SourceFilechanged identity.To ensure that the compiler is aware of the change, we mark the project
as dirty when a text document is opened. This will cause the project to
call
updateGraph, determine that the file changed versions, and createa new program. This is done so that the Angular compiler can reprocess
the file.
This also appears to be one of, if not the only issue, that's currently
causing the e2e tests to be flaky.