Skip to content

fix(language-server): rename response should use URI instead of fileName #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix(language-server): rename response should use URI instead of fileName #1462

merged 1 commit into from
Jul 28, 2021

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jul 28, 2021

fixes #1460

@atscott atscott added the target: patch This PR is targeted for the next patch release label Jul 28, 2021
@google-cla google-cla bot added the cla: yes label Jul 28, 2021
zarend
zarend approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atscott atscott added the action: merge Ready to merge label Jul 28, 2021
@atscott atscott merged commit 8112841 into angular:master Jul 28, 2021
atscott added a commit that referenced this pull request Jul 28, 2021
@atscott
fix(language-server): rename response should use URI instead of file …
49d81aa 
…name (#1462)

fixes #1460

(cherry picked from commit 8112841)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zarend zarend zarend approved these changes

Assignees
No one assigned
Labels
action: merge Ready to merge cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use proper file URI in server
2 participants
@atscott @zarend