Skip to content

test: update default timeout inteval to 30 seconds #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jul 28, 2021

This change is an effort to reduce the flakiness of the e2e tests on macos.
If those e2e tests are still still flaky after this change, we should consider them for macos.

example failure due to timeout: https://github.com/angular/vscode-ng-language-service/runs/3186857720

This change is an effort to reduce the flakiness of the e2e tests on macos.
If those e2e tests are still still flaky after this change, we should consider them for macos.
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jul 28, 2021
@google-cla google-cla bot added the cla: yes label Jul 28, 2021
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@atscott atscott added the action: merge Ready to merge label Jul 28, 2021
@atscott atscott merged commit a546f55 into angular:master Jul 28, 2021
atscott added a commit that referenced this pull request Jul 28, 2021
This change is an effort to reduce the flakiness of the e2e tests on macos.
If those e2e tests are still still flaky after this change, we should consider them for macos.

(cherry picked from commit a546f55)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants