refactor(server): Prefer null over undefined and explicit void
#1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update return types of functions to: * Explicitly have `void` as the return type * Prefer `null` over `undefined` The LSP spec always uses `null` as the return types: https://microsoft.github.io/language-server-protocol/specifications/specification-current/ In fact, if the server is configured to return `undefined`, it will still be `null` after coming through the LSP connection. To avoid any confusion, we should just always use `null`.
atscott
changed the title
null over undefined and explicit void
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update return types of functions to:
voidas the return typenulloverundefinedThe LSP spec always uses
nullas the return types:https://microsoft.github.io/language-server-protocol/specifications/specification-current/
In fact, if the server is configured to return
undefined, it willstill be
nullafter coming through the LSP connection. To avoid anyconfusion, we should just always use
null.