build: update dependency to latest v13 release and fix errors #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
target: major
atscott
force-pushed
the
v13update
branch
5 times, most recently
from
207c989 to
8c37df9
Compare
alxhub
approved these changes
Oct 11, 2021
atscott
force-pushed
the
v13update
branch
2 times, most recently
from
4146ad2 to
8046626
Compare
The latest v13 release of the language service removes the option to disable Ivy from the `PluginConfig`. This commit also removes it from the session configuration, but does not add a workaround to continue supporting View Engine. That will need to be done before the v13 release. In addition, the `esModuleInterop` option was enabled, which matches the angular/angular repo. This addresses another build issue due to default import/exports.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest v13 release of the language service removes the option to
disable Ivy from the
PluginConfig. This commit also removes it fromthe session configuration, but does not add a workaround to continue
supporting View Engine. That will need to be done before the v13
release.
In addition, the
esModuleInteropoption was enabled, which matches theangular/angular repo. This addresses another build issue due to default
import/exports.
reviewer note: the fixup commit is because the package format changes in angular/angular seem to have broken us. We can revert that once we figure out what's broken there.