Skip to content

refactor: support resolving ngcc from pre-v13 package format #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ jobs:
- node/install-packages:
app-dir: integration/project
pkg-manager: yarn
- node/install-packages:
app-dir: integration/pre_apf_project
pkg-manager: yarn
- node/install-packages:
app-dir: integration/workspace
pkg-manager: yarn
Expand Down
11 changes: 11 additions & 0 deletions integration/pre_apf_project/app/app.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import {Component, EventEmitter, Input, Output} from '@angular/core';

@Component({
selector: 'my-app',
template: `<h1>Hello {{name}}</h1>`,
})
export class AppComponent {
name = 'Angular';
@Input() appInput = '';
@Output() appOutput = new EventEmitter<string>();
}
17 changes: 17 additions & 0 deletions integration/pre_apf_project/app/app.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import {CommonModule} from '@angular/common';
import {NgModule} from '@angular/core';
import {AppComponent} from './app.component';
import {FooComponent} from './foo.component';

@NgModule({
imports: [
CommonModule,
],
declarations: [
AppComponent,
FooComponent,
],
bootstrap: [AppComponent]
})
export class AppModule {
}
4 changes: 4 additions & 0 deletions integration/pre_apf_project/app/foo.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{{title | uppercase}}
<span class="subtitle">
subtitle
</span>
8 changes: 8 additions & 0 deletions integration/pre_apf_project/app/foo.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import {Component} from '@angular/core';

@Component({
templateUrl: 'foo.component.html',
})
export class FooComponent {
title = 'Foo Component';
}
12 changes: 12 additions & 0 deletions integration/pre_apf_project/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "angular-ls-integration-test-project",
"private": true,
"dependencies": {
"@angular/common": "12.2.10",
"@angular/compiler": "12.2.10",
"@angular/compiler-cli": "12.2.10",
"@angular/core": "12.2.10",
"rxjs": "6.6.7",
"zone.js": "0.11.4"
}
}
15 changes: 15 additions & 0 deletions integration/pre_apf_project/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"compilerOptions": {
"moduleResolution": "node",
"experimentalDecorators": true,
"target": "es2015",
"strict": true,
"typeRoots": [
"node_modules/@types"
]
},
"angularCompilerOptions": {
"strictTemplates": true,
"strictInjectionParameters": true
}
}
Loading