Skip to content

refactor(client): Support VE by using the v12 version of the language… #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Oct 15, 2021

… server/service

Support for View Engine is dropped in the compiler in the v13 release.
We still want to support VE for the language service while people
upgrade projects. To do this, we launch the v12 server and use the v12
language service with the VE flag flipped on.

@google-cla google-cla bot added the cla: yes label Oct 15, 2021
@atscott atscott requested a review from alxhub October 15, 2021 17:54
@atscott atscott added the target: major This PR is targeted for the next major release label Oct 15, 2021
@atscott atscott force-pushed the supportVeInClientWithNpm branch from 21a2df1 to f1a7d21 Compare October 15, 2021 17:57
… server/service

Support for View Engine is dropped in the compiler in the v13 release.
We still want to support VE for the language service while people
upgrade projects. To do this, we launch the v12 server and use the v12
language service with the VE flag flipped on.
@atscott atscott force-pushed the supportVeInClientWithNpm branch from f1a7d21 to 14ad4a2 Compare October 15, 2021 20:25
@atscott atscott added the action: merge Ready to merge label Oct 15, 2021
@atscott atscott merged commit b9d8bc7 into angular:master Oct 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants