feat(extension): Support renaming from TypeScript files #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The plugin code move into this PR |
ivanwonder
force-pushed
the
disable-built-in-rename-provide
branch
from
ba817c0 to
9fb4cd3
Compare
Closed
14 tasks
atscott
added
the
blocked
|
Adding the blocked label. This has to wait for the 13.2 release here since we don't yet have a branch for the next version that angular/angular#44696 was included in. |
ivanwonder
force-pushed
the
disable-built-in-rename-provide
branch
from
9fb4cd3 to
3dd53d0
Compare
atscott
requested changes
Jan 31, 2022
There was a problem hiding this comment.
@ivanwonder LGTM aside from the commit message. Like the other commit, could you write it as the feature you're providing rather than the implementation details about how that was achieved?
That is:
feat(extension): Support renaming from TypeScript files
<<details about how you did this. Disable rename provider of built in
TS extension so VSCode asks the Angular Language Service for the answer instead. >>
This PR will add a new package that is applied to the built-in TS extension by the config [`typescriptServerPlugins`][1] and is used to disable rename provider of the built-in TS extension so VSCode asks the Angular Language Service for the answer instead. Detail about this package is [here][2]. [1]: https://code.visualstudio.com/api/references/contribution-points#contributes.typescriptServerPlugins [2]: https://github.com/angular/angular/blob/master/packages/language-service/README.md#override-rename-ts-plugin
ivanwonder
force-pushed
the
disable-built-in-rename-provide
branch
from
3dd53d0 to
a898b11
Compare
ivanwonder
changed the title
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new package that is applied to the built-in TS
extension by the config
typescriptServerPluginsand is usedto disable rename provider of the built-in TS extension so VSCode
asks the Angular Language Service for the answer instead.
Detail about this package is here.