feat(server): Definitions for sources compiled with declarationMap …
#1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go to original source The TypeScript language service has the ability to map definitions back to their original source when the library code was compiled with `declarationMap`. However, this functionality is not exposed as public API. As a result, these methods could change in the future without our knowledge. resolves angular#1588
ivanwonder
reviewed
Jan 21, 2022
ivanwonder
approved these changes
Jan 26, 2022
Edit: 😅 I felt bad not having a test. The test project wasn't set up with the CLI so it was an exercise in understanding how to do things manually but I was able to get it working. |
…onMap` go to original source
atscott
force-pushed
the
mappedDefinitionInfo
branch
from
e46aabf to
0ce24af
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…go to original source
The TypeScript language service has the ability to map definitions back
to their original source when the library code was compiled with
declarationMap. However, this functionality is not exposed as publicAPI. As a result, these methods could change in the future without our knowledge.
resolves #1588