refactor: use built-in WorkDoneProgressReport to report NGCC progress
#1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
atscott
reviewed
Feb 28, 2022
|
This is actually a really nice cleanup. Could you provide some more details in the commit message about how this accomplishes the same thing as before, but with much less code? That is, drop in some of the context from #1607 (comment) and other comments in that thread. |
Now the Angular extension implements the `WorkDoneProgressReport` by itself on the client-side to support the multi-report progress with different `tsconfig.json`, to show an error message, to dispose of the report progress, but it's already a built-in feature that can be used on the service side. On the service side, the built-in `WorkDoneProgressReport` will attach a unique token to the different report progress and clean the progress when the client is closing. On the service side, If an error report when running NGCC, the LSP also supports showing an error message in VSCode, but the ability to open the output channel is not supported(now the LSP only supports to open the document URI). This PR will only need to provide it. So the custom `WorkDoneProgressReport` can be removed on the client side.
ivanwonder
force-pushed
the
refactor-progress-report
branch
from
71fe4a5 to
1a6005c
Compare
|
After the tip |
atscott
added
target: patch
2 tasks
atscott
pushed a commit
that referenced
this pull request
Mar 1, 2022
…ss (#1614) Now the Angular extension implements the `WorkDoneProgressReport` by itself on the client-side to support the multi-report progress with different `tsconfig.json`, to show an error message, to dispose of the report progress, but it's already a built-in feature that can be used on the service side. On the service side, the built-in `WorkDoneProgressReport` will attach a unique token to the different report progress and clean the progress when the client is closing. On the service side, If an error report when running NGCC, the LSP also supports showing an error message in VSCode, but the ability to open the output channel is not supported(now the LSP only supports to open the document URI). This PR will only need to provide it. So the custom `WorkDoneProgressReport` can be removed on the client side. (cherry picked from commit 5157872)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the Angular extension implements the
WorkDoneProgressReportby itself on the client-side to support the multi-report progress
with different
tsconfig.json, to show an error message, todispose of the report progress, but it's already a built-in feature
that can be used on the service side.
On the service side, the built-in
WorkDoneProgressReportwillattach a unique token to the different report progress and clean
the progress when the client is closing.
On the service side, If an error report when running NGCC, the LSP
also supports showing an error message in VSCode, but the ability to
open the output channel is not supported(now the LSP only supports
to open the document URI). This PR will only need to provide it.
So the custom
WorkDoneProgressReportcan be removed on the client side.