feat: Add option to disable ngcc #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running ngcc is required for gathering metadata information of libraries not published with Ivy instructions. However, ngcc can also be run manually _outside_ of the extension. Developers may often be running a dev server which does this step so doing it in the extension as well is redundant. In addition, there have been issues with running it in VSCode (angular#1353, angular#1444, and potentially other Nx related issues). This option gives developers the ability to manually opt out of running ngcc from the extension if it is proving to be problematic for their setup. Fixes angular#1353
alxhub
approved these changes
Mar 29, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running ngcc is required for gathering metadata information of libraries
not published with Ivy instructions. However, ngcc can also be run
manually outside of the extension. Developers may often be running a dev
server which does this step so doing it in the extension as well is
redundant. In addition, there have been issues with running it in VSCode
(#1353, #1444, and potentially other Nx related issues).
This option gives developers the ability to manually opt out of running
ngcc from the extension if it is proving to be problematic for their
setup.
Fixes #1353