feat: add command to run ngcc manually #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a command to manually run ngcc for a given file. This commit also refactors the `disableNgcc` option to indicate that it's disabling the _automatic_ `ngcc` run but it can still be triggered manually with the new command. The `disableAutomaticNgcc` option and new command to manually run ngcc are complementary. We have found that the extension can be overzealous in automatically running ngcc, especially with solution-style project configurations (common practice in Nx projects). If a dev server is not active to rerun ngcc when needed, then the new command gives an easy way to do that when the `disableAutomaticNgcc` option is set. Fixes angular#991
alxhub
approved these changes
Apr 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command to manually run ngcc for a given file. This commit also
refactors the
disableNgccoption to indicate that it's disabling theautomatic
ngccrun but it can still be triggered manually with thenew command.
The
disableAutomaticNgccoption and new command to manually run ngccare complementary. We have found that the extension can be overzealous
in automatically running ngcc, especially with solution-style project
configurations (common practice in Nx projects). If a dev server is not
active to rerun ngcc when needed, then the new command gives an easy way
to do that when the
disableAutomaticNgccoption is set.Fixes #991