Skip to content

fix: Correct syntax highlighting for style.prop.% #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Apr 1, 2022

The previous syntax regex capture did not allow a % symbol at all. This
commit updates the regex to allow the property binding and binding name
to be terminated by 0 or 1 '%' characters.

Fixes #1619

@atscott atscott added target: patch This PR is targeted for the next patch release cla: yes labels Apr 1, 2022
The previous syntax regex capture did not allow a % symbol at all. This
commit updates the regex to allow the property binding and binding name
to be terminated by 0 or 1 '%' characters.

Fixes angular#1619
@atscott atscott force-pushed the propertyBindingPercentTerminator branch from db09598 to 0ce71a9 Compare April 1, 2022 22:55
@atscott atscott added the action: merge Ready to merge label Apr 1, 2022
@atscott atscott merged commit 3848142 into angular:master Apr 1, 2022
atscott added a commit that referenced this pull request Apr 1, 2022
The previous syntax regex capture did not allow a % symbol at all. This
commit updates the regex to allow the property binding and binding name
to be terminated by 0 or 1 '%' characters.

Fixes #1619

(cherry picked from commit 3848142)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript context not recognised on style properies with the % modifer.
2 participants