fix(server): Ensure all projects that finish ngcc re-enable language … #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service features The implementation of the ngcc queue for re-enabling project language service's is incorrect. It unconditionally removes projects from the queue when the ngcc process finishes even if it finished out of order and is waiting for the first project in the queue to finish. This results in later projects never getting the language service re-enabled when the earlier project(s) finally finish ngcc. This fix works towards stabilizing the extension for solution-style projects. Related to angular#876
alxhub
approved these changes
Apr 14, 2022
atscott
added a commit
that referenced
this pull request
Apr 14, 2022
…service features (#1627) The implementation of the ngcc queue for re-enabling project language service's is incorrect. It unconditionally removes projects from the queue when the ngcc process finishes even if it finished out of order and is waiting for the first project in the queue to finish. This results in later projects never getting the language service re-enabled when the earlier project(s) finally finish ngcc. This fix works towards stabilizing the extension for solution-style projects. Related to #876 (cherry picked from commit 5712ab8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…service features
The implementation of the ngcc queue for re-enabling project language
service's is incorrect. It unconditionally removes projects from the
queue when the ngcc process finishes even if it finished out of order
and is waiting for the first project in the queue to finish. This
results in later projects never getting the language service re-enabled
when the earlier project(s) finally finish ngcc.
This fix works towards stabilizing the extension for solution-style projects.
Related to #876