Skip to content

fix(language-server): Fix detection of Angular for v14+ projects #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented May 12, 2022

In v14, the .d.ts file for angular core is now "index.d.ts" rather than "core.d.ts".

fixes #1657

@atscott atscott added the target: patch This PR is targeted for the next patch release label May 12, 2022
alxhub
alxhub previously approved these changes May 12, 2022
In v14, the .d.ts file for angular core is now "index.d.ts" rather than "core.d.ts".

This change happened in ng-packagr/ng-packagr@c6f6e4d

fixes angular#1657
@atscott atscott force-pushed the isExternalAngularCore branch from 3b3f189 to dfda593 Compare May 12, 2022 17:31
@atscott atscott added the action: merge Ready to merge label May 12, 2022
@atscott atscott merged commit d8babe5 into angular:main May 12, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Angular v14 RC
2 participants