build: make dist paths align with source file paths #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
bazel_prefactor
branch
2 times, most recently
from
26e5e7d to
1ce4885
Compare
gregmagolan
commented
Aug 4, 2022
| @@ -43,7 +43,7 @@ export const RunNgccRequest = | |||
| export interface GetTcbResponse { | |||
| uri: lsp.DocumentUri; | |||
| content: string; | |||
| selections: lsp.Range[] | |||
| selections: lsp.Range[]; | |||
gregmagolan
commented
Aug 4, 2022
| @@ -1,3 +1,11 @@ | |||
| /** | |||
| * @license | |||
gregmagolan
force-pushed
the
bazel_prefactor
branch
from
1ce4885 to
f350d63
Compare
This is a pre-factor for migrating to Bazel
gregmagolan
force-pushed
the
bazel_prefactor
branch
from
f350d63 to
c5bc997
Compare
atscott
approved these changes
Aug 4, 2022
atscott
added
target: minor
atscott
pushed a commit
that referenced
this pull request
Aug 4, 2022
This is a pre-factor for migrating to Bazel (cherry picked from commit 69fad33)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-factor for migrating to Bazel in #1732.
The
../commonrequires are currently working because things are re-rooted in thedistfolder and dist is a rootPath. Under bazel, output js files are in the same path structure as input ts files so relative requires should match the source tree structure since there is no re-rooting.