Skip to content

build: update to TS 4.8.2 and Angular 14.2.0. #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Sep 6, 2022

This update is necessary to fix an issue in which the language service reports phantom errors, due to some changes in the way TS handles decorators.

@dylhunn dylhunn added target: patch This PR is targeted for the next patch release action: merge Ready to merge labels Sep 6, 2022
@dylhunn dylhunn requested a review from devversion September 6, 2022 23:02
@dylhunn dylhunn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 6, 2022
@dylhunn
Copy link
Contributor Author

dylhunn commented Sep 6, 2022

After this is merged I will cut the 14.2 minor release.

@ivanwonder
Copy link
Contributor

ebc49e8

is @angular/language-service under server missing?

@dylhunn
Copy link
Contributor Author

dylhunn commented Sep 7, 2022

ebc49e8

is @angular/language-service under server missing?

Yes, thank you, good catch!

@dylhunn dylhunn force-pushed the vscode-version-bump branch from ee7b70f to d18c48b Compare September 7, 2022 00:52
@dylhunn dylhunn force-pushed the vscode-version-bump branch 2 times, most recently from 78dd0da to ff38373 Compare September 7, 2022 21:40
This update is necessary to fix [an issue](angular#1746) in which the language service reports phantom errors, due to some [changes](https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#decorators-are-placed-on-modifiers-on-typescripts-syntax-trees) in the way TS handles decorators.
@dylhunn dylhunn force-pushed the vscode-version-bump branch from ff38373 to a09008e Compare September 7, 2022 21:55
@dylhunn dylhunn merged commit 58e5784 into angular:main Sep 7, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension breaks after updating to latest Angular v14.2.0 & Typescript 4.8.2
4 participants