build: run bazel tests on CI and generate bazel built dist/npm_bazel folder #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
gregmagolan
force-pushed
the
migrate_to_bazel_2
branch
3 times, most recently
from
13afaba to
e7f6121
Compare
gregmagolan
force-pushed
the
migrate_to_bazel_2
branch
2 times, most recently
from
3a5440c to
105c467
Compare
atscott
added
target: patch
atscott
approved these changes
Oct 17, 2022
gregmagolan
force-pushed
the
migrate_to_bazel_2
branch
3 times, most recently
from
6aad74b to
ad2e3ea
Compare
…folder Next steps after this are testing of all local workflows and cut-over to a bazel built release. Will co-ordinate with Angular team on this.
gregmagolan
force-pushed
the
migrate_to_bazel_2
branch
from
ad2e3ea to
607f6fb
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next steps after this are testing of all local workflows and cut-over to a bazel built release. Will co-ordinate with Angular team on this.
Release process wiki at https://github.com/angular/vscode-ng-language-service/wiki/Release will need updating for cut-over. In particular, package.json version should be changed to "0.0.0-PLACEHOLDER" and the
version.bzlVERSIONvalue will be the source of truth for the release version.e2e tests (legacy & bazel) are not currently run on CI. I tested the bazel e2e test locally
and it brings up vscode, exercises it and passes locally