fix: use workspace version of typescript server in yarn pnp mode #1763
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
allow the language service to use workspace version of typescript server, by fixing the resolve function. automatic ngcc must be disabled in plugin options Fixes angular#1748
ld210
force-pushed
the
fix-yarn-pnp-compatibility
branch
from
9e7bf4b to
d07d68a
Compare
| export function resolve(packageName: string, location: string, rootPackage?: string): NodeModule | | ||
| undefined { | ||
| const isYarnModule = location.startsWith('.yarn/sdks'); | ||
| location = isYarnModule ? '.yarn/sdks' : location; |
There was a problem hiding this comment.
This fix looks reasonable to me- but would there also be a way of just respecting the VSCode typescript.tsdk setting? This is the one that Yarn sets as well and this would be more flexible without hard-coding to Yarn.
There was a problem hiding this comment.
That's why i was a little hesitant to make a PR, it's a bit of a dirty fix. I went for the jugular ^^
Anyway, thanks @atscott for the proper fix !
There was a problem hiding this comment.
@ld210 PRs serve to get the ball rolling :) Thanks for the detailed information in your issue report. It helped a lot to reproduce things on my end.
|
Superseded by #1765. The comment from @devversion made me remember that we already look at the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In Yarn PnP mode, the language service must use the workspace version of the typescript server. Because of the lack of node_modules folder, it falls back to its own version. This PR allows the language service to work in Yarn PnP environment. That being said, the user still has to disable automatic ngcc in the plugin options.
This PR fixes issue #1748