fix(build): Adjust pointers to bazel-built directory #1793
Conversation
client/tsconfig.json
Outdated
| @@ -6,7 +6,8 @@ | |||
| "rootDir": "src", | |||
| "rootDirs": [ | |||
| ".", | |||
| "../dist" | |||
| "../dist", | |||
| "../bazel-bin" | |||
There was a problem hiding this comment.
for editor support I'm guessing? or is this load bearing for debugging as well?
There was a problem hiding this comment.
I'll revert this. I was seeing an error in my editor that was saying something along the lines of ...dist/common/resolver wasn't built from source ...common/resolver.ts. Which could make sense because we don't actually build anything with tsc and put it in the dist folder.
| @@ -490,7 +490,7 @@ function getServerOptions(ctx: vscode.ExtensionContext, debug: boolean): lsp.Nod | |||
| // Node module for the language server | |||
| const args = constructArgs(ctx, viewEngine, vscode.workspace.isTrusted); | |||
| const prodBundle = ctx.asAbsolutePath('server'); | |||
| const devBundle = ctx.asAbsolutePath(path.join('dist', 'server', 'src', 'server.js')); | |||
| const devBundle = ctx.asAbsolutePath(path.join('bazel-bin', 'server', 'src', 'server.js')); | |||
There was a problem hiding this comment.
this one is surprising? needed for debugging or for some other reason?
There was a problem hiding this comment.
This is when running the extension how locally. We don't copy anything from bazel-bin to dist so this is definitely necessary.
|
LGTM |
atscott
added
action: merge
Prior commits have migrated this project to have its outputs built by bazel. As a result the pointers to the dist folder need to be updated to bazel-bin.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Prior commits have migrated this project to have its outputs built by bazel. As a result the pointers to the dist folder need to be updated to bazel-bin.