fix: fix "install local @angular/language-service" workflow under Bazel build #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
gregmagolan
commented
Nov 18, 2022
| @@ -56,6 +56,8 @@ build --enable_runfiles | |||
| # Keep tests tagged "exclusive" in the sandbox | |||
| test --incompatible_exclusive_test_sandboxed | |||
|
|
|||
| build --build_tests_only | |||
There was a problem hiding this comment.
vsce release build fails in a strange way during one of its npm operations when the local @angular/language-service packages are install. This flag makes it so yarn test only builds targets that are needed for the tests being run.
dylhunn
approved these changes
Nov 18, 2022
dylhunn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for #1815.
This is safe to land before any of the other fixes required do as it doesn't change anything here. Fix won't be in effect until rules_js & angular PRs land and this repo is updated to a release of rules_js that includes the its fixes.
See issue for details.