Skip to content

build: update to latest aspect_bazel_lib, aspect_rules_js, aspect_rules_jasmine and aspect_rules_esbuild #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Mar 5, 2023

There is a regression with worker mode in this release of rules_ts for Node 14 (works fine with Node 16) I disabled it in the ts_project targets in the PR. Sahin is working on a fix for Node 14 worker mode but the ts_project targets in the repository are small so worker mode doesn't add much anyway.

The latest version of rules_js will keep your pnpm-lock.yaml files up-to-date automatically (when your source-of-truth is a yarn.lock file) when any of the inputs to the npm_translate_lock repository rule change. The .aspect/rules/external_repository_action_cache/npm_translate_lock_* files act like an action cache to know when to re-run pnpm import to update the pnpm lock files.

UPDATE: Node 14 worker mode issue is now fixed in rules_ts 1.3.2 (with rules_js 1.20.3 transitive dep)

@atscott atscott added target: patch This PR is targeted for the next patch release action: merge Ready to merge labels Mar 6, 2023
@gregmagolan
Copy link
Contributor Author

I also recommend setting ASPECT_RULES_JS_FROZEN_PNPM_LOCK on CI so that if the pnpm lock file is out of date you'll get a red build. https://docs.aspect.build/rules/aspect_rules_js/docs/pnpm#update_pnpm_lock

@devversion
Copy link
Member

@gregmagolan is there a link for the regression so we can know when to remove the worker disabling?

@gregmagolan
Copy link
Contributor Author

@gregmagolan is there a link for the regression so we can know when to remove the worker disabling?

Fix is underway: aspect-build/rules_js#927

… file is flagged

In the migration period, until we decide to switch to `pnpm` fully, a pnpm lock file needs to be kept in sync. By default, `rules_js` will try to sync it automatically, but rather we would want to flag it as an error on CI if the pnpm file is outdated- so that not all users need to pay the cost of having to run `pnpm import` from time to time.
@angular-robot angular-robot bot requested a review from atscott March 7, 2023 14:31
@gregmagolan
Copy link
Contributor Author

ts_project worker mode re-enabled with the latest rules_js & rules_ts releases cut this morning. I also greened up the other CI failure. This should be clear to land now

@devversion
Copy link
Member

@gregmagolan I have a conflict-resolved version of your PR, along with the environment variable: #1873

@atscott atscott closed this Mar 9, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants