Skip to content

feat(syntaxes): Support inline styles as string #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Sep 12, 2023

angular/angular@59387ee

The above commit added support for inline styles to be a single string literal in addition to the previous array of strings. This commit updates the syntaxes regex of the extension to support this feature.

angular/angular@59387ee

The above commit added support for inline styles to be a single string literal in addition
to the previous array of strings. This commit updates the syntaxes regex of the extension
to support this feature.
@atscott atscott added the target: minor This PR is targeted for the next minor release label Sep 12, 2023
The client code has an optimization which skips making requests to the server for Angular results
when the position is outside a context that Angular would be interested in. This commit
adds the 'styleUrl' property to those properties of interest.
@atscott atscott added the action: merge Ready to merge label Sep 14, 2023
@atscott atscott merged commit bc6e1ff into angular:main Sep 18, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge detected: feature target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants