Skip to content

refactor(client): Show warning message if a project uses a newer vers… #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Oct 19, 2023

…ion than extension

When the installed extension version is less than the major version of the project, there is likely to be errors. Because new features are added in major/minor releases, a the bundled compiler version in an old extension version may completely fail to even parse a template if there are new syntax features. This problem is very apparent with the new control flow syntax. If a project uses v17 and uses the new control flow, a v16 language service will show all kinds of parse errors.

fixes #1941

@atscott atscott added the target: patch This PR is targeted for the next patch release label Oct 19, 2023
…ion than extension

When the installed extension version is less than the major version of the
project, there is likely to be errors. Because new features are added in
major/minor releases, a the bundled compiler version in an old extension version
may completely fail to even parse a template if there are new syntax features.
This problem is very apparent with the new control flow syntax. If a project uses
v17 and uses the new control flow, a v16 language service will show all kinds of parse errors.

fixes angular#1941
@atscott atscott force-pushed the warnIfProjectIsNewerThanExtension branch from 63498df to 45b7678 Compare October 19, 2023 20:01
@atscott atscott added action: merge Ready to merge target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 19, 2023
@atscott atscott merged commit 769e209 into angular:main Oct 19, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warning when extension version is less than the project version
2 participants