fix(syntaxes): Adjust block syntax highlighting to require ( or { on … #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Nov 8, 2023
atscott
force-pushed
the
requireBraceOrParenOnBlockLineForSyntaxes
branch
from
24fa330 to
f194d30
Compare
atscott
added
target: major
…same line While our parser allows for a block name to be defined on a separate line from the expression or brace, the syntax highlighting will not. Because the extension may be used for older versions of Angular and we cannot turn highlighting on and off dynamically like we can the parser, we make the highlighting more restrictive. This should cover a majority of use-cases where `@` is used in older versions of Angular like in emails and _not_ begin block highlighting. Partially addresses angular#1958. Will need another change to detect Angular version and disable block parsing.
atscott
force-pushed
the
requireBraceOrParenOnBlockLineForSyntaxes
branch
from
f194d30 to
832564d
Compare
dylhunn
approved these changes
Nov 8, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…same line
While our parser allows for a block name to be defined on a separate line from the expression or brace, the syntax highlighting will not. Because the extension may be used for older versions of Angular and we cannot turn highlighting on and off dynamically like we can the parser, we make the highlighting more restrictive. This should cover a majority of use-cases where
@is used in older versions of Angular like in emails and not begin block highlighting.Partially addresses #1958. Will need another change to detect Angular version and disable block parsing.