Skip to content

feat(language-service): Allow specific diagnostics to be suppressed #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Sep 6, 2024

Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

In addition to providing an easily patchable array and a command-line option, it's also wired up to the extension settings:
ng-ignore-diagnostic

Fixes #1243

@dylhunn dylhunn added the target: minor This PR is targeted for the next minor release label Sep 6, 2024
@dylhunn dylhunn requested a review from atscott September 6, 2024 23:56
@dylhunn dylhunn force-pushed the plugin-config-ignore-diag branch 8 times, most recently from c25356d to ed84dc6 Compare September 9, 2024 19:17
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
@atscott atscott force-pushed the plugin-config-ignore-diag branch from ed84dc6 to 523ae17 Compare September 10, 2024 16:36
@atscott atscott merged commit 7c13306 into angular:main Sep 10, 2024
5 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
detected: feature target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter diagnostics of certain error codes
2 participants