Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Some application break on specific mobile device or environment. #1098

Closed
wants to merge 1 commit into from
Closed

Some application break on specific mobile device or environment. #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/zone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,17 @@ const Zone: ZoneType = (function(global: any) {
}
}
if (nativeMicroTaskQueuePromise) {
nativeMicroTaskQueuePromise[symbolThen](drainMicroTaskQueue);
if (typeof nativeMicroTaskQueuePromise[symbolThen] === FUNCTION) {
nativeMicroTaskQueuePromise[symbolThen](drainMicroTaskQueue);
} else if (typeof nativeMicroTaskQueuePromise.then === FUNCTION) {
nativeMicroTaskQueuePromise.then(drainMicroTaskQueue);
} else {
console.error(`Cannot found Promise#then method. Please add polyfill to using \`Promise\`. If you already did that. Perhaps Promise#then is not writeable. If you want to use it. add following codes to your \`polyfill.ts\` after \`import 'zone.js/dist/zone'\`

if (!(Promise.prototype as any)['__zone_symbol__then']) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code should not be added here, because it means the current microTask will not be scheduled. If you think this logic need to be handled, you need to add the logic to patchThen method, but I don't think we need to handle old browser like chrome 34.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not code. just part of template string.

Copy link
Collaborator

@JiaLiPassion JiaLiPassion Jun 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. got it, in fact, I forget I already fixed this one in #1079. So please wait for the next release.

Copy link
Author

@johnny-mh johnny-mh Jun 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No #1079 is not initialize Promise.__zone_symbol__then because Promise.then is not patchable OK?

~~The problem is https://github.com/angular/zone.js/pull/1098/files/d4ac887fd112c3fde3a167223c42ecbac76c1f14#diff-dd469785fca8680a5b33b1e81c5cfd91R1276 ~~

nativeMicroTaskQueuePromise is Promise and symbolThen is '__zone_symbol__then. so Invoking Promise. __zone_symbol__then` is always throwing error.

But some case. Promise.then is not patchable but the error message only undefined is not function and no other error message, no error stack trace. in this case It's very hard to find this problem.

It is not problem of only old browser. If some library set Promise.then to not patchable. developer will be face this problem and searching what is the matter of this error message.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JiaLiPassion Oh #1079 is exactly i want. I will wating next release. 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sure, thank you for reporting the issue.

(Promise.prototype as any)['__zone_symbol__then'] = Promise.prototype.then;
}`);
}
} else {
global[symbolSetTimeout](drainMicroTaskQueue, 0);
}
Expand Down