This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(element): Fix native_shim.js not implement adoptedCallback error. #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
Jan 19, 2019
| @@ -26,7 +26,7 @@ function patchCallbacks(target: any, targetName: string, method: string, callbac | |||
| if (descriptor && descriptor.value) { | |||
| descriptor.value = wrapWithCurrentZone(descriptor.value, source); | |||
| _redefineProperty(opts.prototype, callback, descriptor); | |||
| } else { | |||
| } else if (prototype[callback]) { | |||
There was a problem hiding this comment.
There is already a check for prototype.hasOwnProperty(callback) a few lines above.
Does it mean that the properties exists, but are falsy? (That would be unexpected.)
There was a problem hiding this comment.
Yes, hasOwnProperty return true, but prototype[call back] is undefined.
Some case like this.
var a = {
key: undefined
};
console.log('hasOwnProperty', a.hasOwnProperty('key')); // output is true
console.log('prop', a.key); // output is undefined.
gkalpak
approved these changes
Jan 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pass test in
angular, we need to handle some ofcallbacksare not implemented by somepolyfilles.@webcomponent/native_shim.jsdoesn't implementadopdatedCallback,zone.jswill throw error, so we need to check this case.