Merge pull request #79 from erikma/dev/erikmav/disposeWinIdentity

fluffynuts · web-flow · commit 0dbdc6d2f69a · 2021-12-16T08:59:22.000+02:00
diff --git a/src/log4net/Core/LoggingEvent.cs b/src/log4net/Core/LoggingEvent.cs
@@ -937,8 +937,10 @@ private static string TryGetCurrentUserName()
 
             try
             {
-                var windowsIdentity = WindowsIdentity.GetCurrent();
-                return windowsIdentity?.Name ?? "";
+                using (WindowsIdentity windowsIdentity = WindowsIdentity.GetCurrent())
+                {
+                    return windowsIdentity?.Name ?? "";
+                }
             }
             catch (PlatformNotSupportedException)
             {

Original file line number	Diff line number	Diff line change
`@@ -937,8 +937,10 @@ private static string TryGetCurrentUserName()`
`937`	`937`
`938`	`938`	`try`
`939`	`939`	`{`
`940`		`- var windowsIdentity = WindowsIdentity.GetCurrent();`
`941`		`- return windowsIdentity?.Name ?? "";`
	`940`	`+ using (WindowsIdentity windowsIdentity = WindowsIdentity.GetCurrent())`
	`941`	`+ {`
	`942`	`+ return windowsIdentity?.Name ?? "";`
	`943`	`+ }`
`942`	`944`	`}`
`943`	`945`	`catch (PlatformNotSupportedException)`
`944`	`946`	`{`