Add Laravel 9 support #18

christoph-kluge · 2022-02-10T14:59:33Z

Description

In general tests look good for L9 + PHP8+ but changes are not backward compatible

Waiting for dependent packages

Add Laravel 9 Support dingo/blueprint#90

Tests overview

❌ Laravel 8 + PHP 7.4.15 (fail due to php incompatible function calls)
❌ Laravel 8 + PHP 8.0.15 (2 tests break because of mismatching type - symfonys repsonse getContent() changed return behavior)
❌ Laravel 8 + PHP 8.1.2 (fail due to php incompatible function calls)
✅ Laravel 9 + PHP 8.0.15
✅ Laravel 9 + PHP 8.1.2

Install instructions

Test and install this locally first. Thanks to @tobias-kuendig for sharing the instructions.

composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url":  "https://github.com/christoph-kluge/dingo-api"
        },
        {
            "type": "vcs",
            "url":  "https://github.com/dmason30/blueprint"
        }
    ],

Then require the package like so:

composer require api-ecosystem-for-laravel/dingo-api dev-laravel-9-support

christoph-kluge · 2022-02-10T16:21:18Z

Missing php 8.1 support using dev version for now thephpleague/fractal#526

christoph-kluge · 2022-02-11T08:53:54Z

This addresses #15 #16 #17

…d behavior

…->noContent() was breaking due to "null" values for getContent(). The proper fix seems to ensure we always have an empty "string"

suguer · 2022-02-14T06:02:56Z

now laravel9 illuminate/routing version is 9.0 but dingo-api just require ^7.0|^8.0
how can i fix it

christoph-kluge · 2022-02-14T07:26:11Z

@suguer without further details it's hard to tell. My first quess: You're using the wrong version and/or fork.

Did you add my fork as repository to your composer.json?

https://getcomposer.org/doc/05-repositories.md

suguer · 2022-02-14T07:34:29Z

@christoph-kluge
Did you add my fork as repository to your composer.json? no , I do not change my composer.json anything

this is my full command output

Using version ^3.1 for api-ecosystem-for-laravel/dingo-api
./composer.json has been updated
Running composer update api-ecosystem-for-laravel/dingo-api
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires api-ecosystem-for-laravel/dingo-api ^3.1 -> satisfiable by api-ecosystem-for-laravel/dingo-api[v3.1.0, v3.1.1].
- api-ecosystem-for-laravel/dingo-api[v3.1.0, ..., v3.1.1] require illuminate/routing ^7.0|^8.0 -> found illuminate/routing[v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but it conflicts with your root composer.json require (^9.0).

You can also try re-running composer require with an explicit version constraint, e.g. "composer require api-ecosystem-for-laravel/dingo-api:*" to figure out if any version is installable, or "composer require api-ecosystem-for-laravel/dingo-api:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

christoph-kluge · 2022-02-14T07:52:13Z

I see. So without changing your composer you'll be not able to test my fork. This pull-request is just a proposal to this library and does not necessarily mean that the maintainers will merge it.

If you want to test my non-official fork then you should to explicitly define this in your composer.json.

https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository

suguer · 2022-02-14T10:24:35Z

ok. take the liberty to ask .what parameters should I write to composer.json .
I don't know how to write composer.json very well
thx very much

suguer · 2022-02-16T08:03:02Z

@christoph-kluge
excuse me , can you teach me how to write to composer.json .
I try it, but failure

christoph-kluge · 2022-02-16T19:30:52Z

@suguer please check out the last link to the composer documentation how to load a package from vcs. You need my fork's github-url and the branch name. You can find this information on top of this page right below the title of the PR and replace the values in these examples.

If you click on my source branch you'll get redirected to my fork's URL and the branch. https://github.com/christoph-kluge/dingo-api and laravel-9-support. It's important to prefix dev-{branchname} as mentioned in the documentation.

suguer · 2022-02-17T01:40:34Z

okk, my composer.json is right , but still failed

when i run "composer update"

Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires api-ecosystem-for-laravel/dingo-api dev-laravel-9-support -> satisfiable by api-ecosystem-for-laravel/dingo-api[dev-laravel-9-support].
- api-ecosystem-for-laravel/dingo-api dev-laravel-9-support requires dingo/blueprint dev-patch-1 -> found dingo/blueprint[dev-chore/laravel-7-compat, dev-master, v0.1.0, ..., v0.4.3] but it does not match the constraint.

Endy-c · 2022-02-21T01:48:40Z

When could this pull request be merged?

tobias-kuendig · 2022-02-21T06:07:33Z

For anyone trying to get @christoph-kluge's PR working locally before it being merged, you need to add these to your composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url":  "[email protected]:christoph-kluge/dingo-api.git"
        },
        {
            "type": "vcs",
            "url":  "[email protected]:dmason30/blueprint.git"
        },
        {
            "type": "vcs",
            "url": "https://github.com/annuh/fractal.git"
        }
    ],

Then require the package like so:

composer require api-ecosystem-for-laravel/dingo-api dev-laravel-9-support

Endy-c · 2022-02-21T06:45:27Z

For anyone trying to get @christoph-kluge's PR working locally before it being merged, you need to add these to your composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url":  "[email protected]:christoph-kluge/dingo-api.git"
        },
        {
            "type": "vcs",
            "url":  "[email protected]:dmason30/blueprint.git"
        },
        {
            "type": "vcs",
            "url": "https://github.com/annuh/fractal.git"
        }
    ],

Then require the package like so:

composer require api-ecosystem-for-laravel/dingo-api dev-laravel-9-support

solved!
extremely grateful!

christoph-kluge · 2022-02-21T09:52:44Z

@tobias-kuendig thank you for adding this here.

I did change the repository-urls from git@ to https:// and added your install instructions to the MR description.

…gge into master

tdavidsonas88 · 2022-05-19T10:56:46Z

composer update passed without errors for me with this guide. Nice! 🎉 The downside that on my project all requests I have gives me 500 Internal Server Error without any backtrace message now. So gonna debug it.

shoosah · 2022-06-01T05:44:43Z

Any idea when does this PR could be merged?

xtieume · 2022-06-19T09:20:10Z

Not working with Fractal

prady00 · 2022-07-26T18:51:22Z

When are we merging this PR?

minkbear · 2022-08-08T05:39:00Z

Waiting this as well

specialtactics · 2022-08-20T08:53:11Z

Hey all, sorry for the wait - I've been absent due to first holiday in 3.5 years, you know how it is 😢

Now that this is in a group though, I am able to and would be happy to give access to people who are committed and able to help maintain this package - please let me know if you are interested!

specialtactics · 2022-08-20T09:08:24Z

Just some updates for versions, #22

Please use tag v4.0.0 to get all the latest changes for laravel 9

christoph-kluge · 2022-08-20T09:58:32Z

@specialtactics I would be interested. Would you be up for a chat regarding short/mid/long-term plans for this lib? Can I reach you in some slack/discord channel?

Back in the days laravel was missing a lot of api-related features. Since then a lot changed and we might reduce a bit of boilerplate within this package.

specialtactics · 2022-08-20T10:05:48Z

Yes @christoph-kluge I agree, are you on the main laravel slack by any chance?

christoph-kluge added 9 commits February 10, 2022 15:00

Add laravel 9 support

886f6bf

Add laravel 9 support

339c6a7

make response compatible with symfony

e196695

symfony throws now an SessionNotFoundException - keep the behavior

a5ddc6e

Removed PHP 7.x and added 8.1

b0e18a9

pin php 8.1.0

8b1544e

Adds laravel 9 stubs for tests

d16556d

Fixed tests

d3474d1

league/fractal is lacking php 8.1 support

3a6385b

christoph-kluge added 2 commits February 11, 2022 09:15

style CI

7b53666

Style CI and added L9 to travis

e0e53b7

christoph-kluge marked this pull request as ready for review February 11, 2022 08:38

christoph-kluge added 2 commits February 11, 2022 11:57

request->getSession() throws and exception with new symfony ; keep ol…

3d393f9

…d behavior

During my api tests I have discovered some scenarios where response()…

19003e1

…->noContent() was breaking due to "null" values for getContent(). The proper fix seems to ensure we always have an empty "string"

christoph-kluge mentioned this pull request Feb 21, 2022

Add support for PHP 8.1 thephpleague/fractal#528

Merged

Moved fractal to ^0.20 after the fork annuh/fractal was merged and ta…

93390e8

…gge into master

christoph-kluge mentioned this pull request Mar 9, 2022

Add Laravel 9 Support dingo/blueprint#90

Merged

michaelvaes mentioned this pull request May 2, 2022

Laravel 9 support specialtactics/l5-api#53

Closed

tdavidsonas88 mentioned this pull request May 19, 2022

Laravel 9 support #16

Closed

specialtactics merged commit 8ca5a1e into api-ecosystem-for-laravel:master Aug 20, 2022

specialtactics mentioned this pull request Aug 20, 2022

Add php 8.1 support #14

Closed

Yoruchiaki mentioned this pull request Jun 7, 2024

Laravel 11 Support #42

Closed

Uh oh!

Add Laravel 9 support #18

Add Laravel 9 support #18

Uh oh!

Conversation

christoph-kluge commented Feb 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Waiting for dependent packages

Tests overview

Install instructions

Uh oh!

christoph-kluge commented Feb 10, 2022

Uh oh!

christoph-kluge commented Feb 11, 2022

Uh oh!

suguer commented Feb 14, 2022

Uh oh!

christoph-kluge commented Feb 14, 2022

Uh oh!

suguer commented Feb 14, 2022

this is my full command output

Uh oh!

christoph-kluge commented Feb 14, 2022

Uh oh!

suguer commented Feb 14, 2022

Uh oh!

suguer commented Feb 16, 2022

Uh oh!

christoph-kluge commented Feb 16, 2022

Uh oh!

suguer commented Feb 17, 2022

when i run "composer update"

Uh oh!

Endy-c commented Feb 21, 2022

Uh oh!

tobias-kuendig commented Feb 21, 2022

Uh oh!

Endy-c commented Feb 21, 2022

Uh oh!

christoph-kluge commented Feb 21, 2022

Uh oh!

tdavidsonas88 commented May 19, 2022

Uh oh!

shoosah commented Jun 1, 2022

Uh oh!

xtieume commented Jun 19, 2022

Uh oh!

prady00 commented Jul 26, 2022

Uh oh!

minkbear commented Aug 8, 2022

Uh oh!

specialtactics commented Aug 20, 2022

Uh oh!

specialtactics commented Aug 20, 2022

Uh oh!

christoph-kluge commented Aug 20, 2022

Uh oh!

specialtactics commented Aug 20, 2022

Uh oh!

Uh oh!

christoph-kluge commented Feb 10, 2022 •

edited

Loading