Skip to content

feat: add support for Laravel 10 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2023

Conversation

patoui
Copy link
Contributor

@patoui patoui commented Feb 18, 2023

Description

Adds support for Laravel 10, ran some tests locally on Laravel 10 (10.0.3/10.6.2) with PHP 8.1 (8.1.12), no errors occurred. 🚀

There is an accompanying pull requests to update dingo/blueprint which can be found here dingo/blueprint#91

To test this locally:

  • create a new Laravel 10 project
  • create a packages directory
  • clone the fork into the packages directory cd packages && git clone https://github.com/patoui/dingo-api
  • within the new Laravel 10 project, update the composer.json with
    "repositories": [
        {
            "type": "path",
            "url": "../packages/*/"
        }
    ],
    "require": {
        "api-ecosystem-for-laravel/dingo-api": "dev-master"
     },
    "minimum-stability": "dev"
  • now within the Laravel 10 project directory run rm -rf composer.lock vendor && composer update

Now you can test dingo-api as you normally would!

EDIT: Updated instructions and composer.json latest tagged version from dingo/blueprint

@patoui
Copy link
Contributor Author

patoui commented Feb 22, 2023

@christoph-kluge / @specialtactics could either of you please review this PR? 🙏🏻

@nasrulhazim
Copy link
Contributor

hopes this PR get approved soon. Been upgrading some of my project that rely on this package.

@hypervision-am
Copy link

Looking forward to the update

LordXaart
LordXaart previously approved these changes Mar 1, 2023
@christoph-kluge
Copy link
Contributor

@patoui thanks for adding L10 support here. Much appreciating your effort here 🚀

dingo/blueprint#91 needs to be merged, released and changed in the composer.json before I can continue on this MR.

@hesomp
Copy link

hesomp commented Mar 28, 2023

any update on an ETA for this? its blocking one of my L10 upgrades.

@patoui
Copy link
Contributor Author

patoui commented Mar 28, 2023

@hesomp waiting on the related PR to be merged, no response from maintainers yet

dingo/blueprint#91 (comment)

ABouchard55
ABouchard55 previously approved these changes Mar 31, 2023
@stueynet
Copy link

stueynet commented Apr 5, 2023

yay! dingo/blueprint#91 was merged 🚀 🚀 . Can we get this one merged next? Thanks so much for everyone's hard work here.

@patoui
Copy link
Contributor Author

patoui commented Apr 5, 2023

I'll run some tests this evening with the new tagged version from dingo/blueprint and push an update for composer.json here if no issues are found 😃

@patoui patoui dismissed stale reviews from ABouchard55 and LordXaart via 054efa6 April 5, 2023 22:56
@patoui
Copy link
Contributor Author

patoui commented Apr 5, 2023

@christoph-kluge I've update the composer.json and re-tested, please review when you have time 🙏🏻 🙇🏻

Ran some additional tests on Laravel 9 and 10 (PHP 8.1.2). Setup some API endpoints with basic auth, didn't run into any issues 👌🏻

image
image

@softwareok1
Copy link

@christoph-kluge @ABouchard55 @LordXaart
Hi any chance to get a reaction here? We need this for some migration projects and it's the only braking change to finish our work. Greetz.

@slaff
Copy link

slaff commented Apr 24, 2023

@christoph-kluge @ABouchard55 @LordXaart any chance of merging this PR?

@softwareok1 softwareok1 mentioned this pull request Apr 26, 2023
@specialtactics specialtactics merged commit ba1ff81 into api-ecosystem-for-laravel:master May 4, 2023
@specialtactics
Copy link
Contributor

Apologies for delay again, I have been away until last week. Thanks for the PR @patoui, merged and tagged as v4.1.0

@patoui
Copy link
Contributor Author

patoui commented May 4, 2023

Thank you so much @specialtactics , very much appreciated 🙏🏻 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.